[*] Make operator compatible with Kubernetes 1.22 #325
Conversation
- Remove API references to v1beta1 CRD API. Previously the operator installed the CRD itself, but with 1.22 it's more common to install the CRD separately (since the schema is fully included in the CRD definition). - Generate the CRD manifest using `controller-gen`. Fixes #323.
schallert
force-pushed
the
schallert/controller_gen
branch
from
a2ad33b
to
826b44f
Compare
| - name | ||
| - value | ||
| type: object | ||
|
|
There was a problem hiding this comment.
Hi @schallert,
Thank you for making this change. I am from Databricks, I've applied the CRD change and build a docker image from this PR to test it out, however the m3db-operator was stuck without creating the m3db-cluster. Any clues about how to debug this? The m3db-operator only produces 5 lines of logs:
~/universe (m3db-operator) $ klgf m3db-operator-0
{"level":"info","ts":"2022-06-28T03:31:24.779Z","msg":"using InCluster k8s config"}
{"level":"info","ts":"2022-06-28T03:31:24.875Z","msg":"starting Operator controller","controller":"m3db-cluster-controller"}
{"level":"info","ts":"2022-06-28T03:31:24.876Z","msg":"waiting for informer caches to sync","controller":"m3db-cluster-controller"}
{"level":"info","ts":"2022-06-28T03:31:25.881Z","msg":"starting workers","controller":"m3db-cluster-controller"}
{"level":"info","ts":"2022-06-28T03:31:25.881Z","msg":"workers started","controller":"m3db-cluster-controller"}
There was a problem hiding this comment.
@jnyi what k8s version is your cluster on? Do you have any other debugging info you can share, i.e. what happens when you do kubectl describe m3dbcluster $CLUSTER?
I haven't been able to reproduce this in any of our environments but definitely want to track it down if it's an issue w/ the operator.
There was a problem hiding this comment.
As a heads up I'm going to land this so we can work on docs. @jnyi if you're on the M3 slack, feel free to ping me and we'll see if we can debug the issue. I'll wait until I hear from Databricks that this is working before we cut a release.
There was a problem hiding this comment.
Sure, will contact you in M3 slack channel.
There was a problem hiding this comment.
Thanks for helping out, tested this change is compatible with kubernetes v1.22
installed the CRD itself, but with 1.22 it's more common to install
the CRD separately (since the schema is fully included in the CRD
definition).
controller-gen.This has been successfully tested in the two main upgrade / install paths:
bundle.yaml.A separate PR will update the docs. Then we'll cut a release so that users don't have to install/apply the operator from the main branch.
Fixes #323.